Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paused game because of missing newgrfs, gets unintentionally unpaused #1733

Closed
DorpsGek opened this issue Feb 1, 2008 · 1 comment
Closed
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 1, 2008

frosch opened the ticket and wrote:

To reproduce:
- Load a game that will get paused because of missing newgrfs.
- Open again the 'load game' dialog from the menu.

This will cause unpausing the game. (Normally game is paused when opening that dialog).

The culprit seams to be the magic around _pause_game.
- Positive values are for paused games.
- Zero is for unpaused games.
- Negative values are for paused games because of missing/incompatible newgrfs.

Opening the 'load game' dialog causes _pause_game to get incremented (normally pauses the games), but because of the negative values it is actually unpaused.

There seems to be a bit more magic around, which I do not understand. (the comments say something about special pause for converting multiplayer to singleplayer)

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1733
@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 4, 2008

peter1138 closed the ticket.

Reason for closing: Fixed

In r12336


This comment was imported from FlySpray: https://bugs.openttd.org/task/1733

@DorpsGek DorpsGek closed this as completed Mar 4, 2008
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant