Gonozal_VIII wrote:

added some assertions to be on the safe side :-)

Attachments

• unmovable_ground_r12015.patch (5.03 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1724#comment3403

SmatZ wrote:

Will it work with unmovables on foundations?
Transmitters and lighthouses could be placed on foundation in the scenario editor before r12014. It wouldn't be nice to assert for old savegames.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1724#comment3404

Gonozal_VIII wrote:

good point smatz... removed assertions and put foundation code back

Attachments

• unmovable_ground_r12015.patch (5.03 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1724#comment3405

Gonozal_VIII wrote:

i found the nice function GetTropicZone that helped a lot with simplifying the patch and now it works with half desert tiles too :-)

Attachments

• unmovable_ground_r12019.patch (4.83 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1724#comment3406

frosch wrote:

+ if (!IsTransparencySet(TO_SIGNS)) {
This is most likely not what you want to do. This hides the owner-land-sign completely, if the background of signs (station names etc) is set to transparent.

About the GetUnmovableGround(): This should be done like everywhere else (clear_ground, trees, etc). I.e. inside TileLoop and with a ground type and density in the map array (try to use the same bits as for clear_ground or trees). Your current approach causes glitches, when only parts of the unmovable are redrawn. Furthermore:
+ switch(GetTileZ(tile) + 8 - GetSnowLine()) {
+ case 0: return SPR_FLAT_1_QUART_SNOWY_TILE; break;
+ case 8: return SPR_FLAT_2_QUART_SNOWY_TILE; break;
+ case 16: return SPR_FLAT_3_QUART_SNOWY_TILE; break;
+ default: return SPR_FLAT_SNOWY_TILE; break;
+ }
Either do that the same way as for clear_ground / trees, or better: Add a function that can be used in all three cases (maybe there are more).

This comment was imported from FlySpray: https://bugs.openttd.org/task/1724#comment3407

Gonozal_VIII wrote:

updated and changed transparency to transparent instead of invisible... i can't do that map array changing stuff, that's too complicated for my knowledge.

Attachments

• unmovable_ground_r12066.patch (4.71 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1724#comment3461

Rubidium closed the ticket.

Reason for closing: Won't implement

Use NewGRF objects for this.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1724