PhilSophus opened the ticket and wrote:

In this topic, Swallow reported a crash during startup of OpenTTD: http://www.tt-forums.net/viewtopic.php?f=31&t=35984

I found out, that this is probably due to an error in DupSprite() in spritecache.cpp:
void DupSprite(SpriteID old_spr, SpriteID new_spr)
{
SpriteCache *scold = GetSpriteCache(old_spr);
SpriteCache *scnew = AllocateSpriteCache(new_spr);
...
}

The call to AllocateSpriteCache may reallocate the _spritecache array letting scold point to invalid memory. Swapping these two lines should solve the issue (see attached patch). This seems to be the only place in the code, that has this problem.

Attachments

• spritecache_fix_r12002.patch (0.51 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1717