Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

road building and removing irregularities #1694

Closed
DorpsGek opened this issue Jan 24, 2008 · 6 comments
Closed

road building and removing irregularities #1694

DorpsGek opened this issue Jan 24, 2008 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

SmatZ opened the ticket and wrote:

r11972

Half-road in screenshot cannot be extended to fullroad. But when it is at SLOPE_NW, it can be extended.
Similiar problem is with removing - removing lower bit of full road removes whole road, not only lower half-road. Even on SLOPE_NW.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1694
@DorpsGek
Copy link
Member Author

SmatZ wrote:

First appeared in r11172-
if the indended behaviour is not to allow extending in any case, then from r11953 should be removed check "if (rtest != rt)". But further town code would need to change to remove half-road first.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1694#comment3344

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 8, 2008

skidd13 wrote:

Patch needs review!

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1694#comment3624

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 9, 2008

peter1138 wrote:

Sorry, but that patch makes it worse. Placing road on the edge of a foundation should not be allowed. It should not just remove the foundation.

In addition with your patch you can't remove the road from the 'top' piece of a slope, only the bottom: and then a foundation is created. This is wrong.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1694#comment3625

@DorpsGek
Copy link
Member Author

skidd13 wrote:

For the log:

Sorry, but that patch makes it worse.
The thing peter1138 described is done by design. I thought that conversion would be nice and userfriendly.

Placing road on the edge of a foundation should not be allowed. It should not just remove the foundation.
Well it converts a leveled dead end on a slope to a downhill road.
This can be helpfull if you want to extend a road and don't want to destroy it first.

In addition with your patch you can't remove the road from the 'top' piece of a slope,
only the bottom: and then a foundation is created. This is wrong.
Well a road on a slope with only the downhill part set is ATM impossible (Well at least there are no sprites).
And a conversion form downhill road to leveled dead end would IMO be nice too and if I
allow to convert between leveled dead end and downhill, I should allow it vice versa.

The terraforming costs are incorporated anyway. Now a decision has to be made.

[EDIT]Expanded the comment to explain my solution a bit more.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1694#comment3641

@DorpsGek
Copy link
Member Author

skidd13 wrote:

Fixed a few bugs and cleaned up code.
Current patch is there. vvv
http://devs.openttd.org/~skidd13/fs1694_v6.patch


This comment was imported from FlySpray: https://bugs.openttd.org/task/1694#comment3676

@DorpsGek
Copy link
Member Author

skidd13 closed the ticket.

Reason for closing: Implemented

in r1694


This comment was imported from FlySpray: https://bugs.openttd.org/task/1694

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant