Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound code refactoring / separation of sound mixer #1691

Closed
DorpsGek opened this issue Jan 24, 2008 · 1 comment
Closed

Sound code refactoring / separation of sound mixer #1691

DorpsGek opened this issue Jan 24, 2008 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Dominik opened the ticket and wrote:

This patch is very much based on Peter's mixer patch. I upgraded it to the latest revision and made the sdlmixer for music and sound effects working. Note that you can't combine -s sdl -m sdlmixer. You can however do -s sdlmixer -m sdlmixer. The Windows code probably needs an upgrade, I don't have the possibility to test it.
Another note about the sdl sound mixer: SDL_Mixer can only handle standard files with wave headers. Thus I'm creating a correct virtual header when a sound sample is loaded. For future revisions it would be best to have a pool of Mix_Chunk samples in memory so that they don't need to be loaded from disk and resampled again. (The current software mixer does the same though.)

Patch is based on r11943

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1691
@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/1691

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant