Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong sprites along coasts for alpine #1683

Closed
DorpsGek opened this issue Jan 23, 2008 · 3 comments
Closed

Wrong sprites along coasts for alpine #1683

DorpsGek opened this issue Jan 23, 2008 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Eddi opened the ticket and wrote:

i noticed this the first time in r11952

previously, the sprites of the grassy half-slopes were used with the alpine grf.

now at the coast, the half slopes near the coast are from the standard arctic graphics are used

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1683
@DorpsGek
Copy link
Member Author

frosch wrote:

In r11726 shore sprites for the 'three-corner-raised'- and steep- slopes were add. However they are only used since r11937.
The alpine grf does not use Action5 (but ActionA) to replace shore graphics. So it does not replace the new slopes witch openttd(w/d).grf loads.

By the way: Do you also miss the graphics for the halftile foundations? Or are you using a grf like tempfndw.grf (second post in http://www.tt-forums.net/viewtopic.php?f=33&t=34298)?
In that case you can do the same with the attached grf.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1683#comment3333

@DorpsGek
Copy link
Member Author

frosch wrote:

Attached patch fixes this. I leave it for discussion over night :)

  1. If shore sprites are neither loaded by Action5 nor ActionA, the extra sprites from openttd(w/d).grf are used.
  2. If a newgrf replaces some shore sprites by ActionA. The (maybe also replaced) grass tiles are used for corner shores.
  3. If a newgrf replaces shore sprites by Action5 any shore replacement by ActionA has no effect.

This seems to be TTDP compatible in all cases.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1683#comment3341

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r11937


This comment was imported from FlySpray: https://bugs.openttd.org/task/1683

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant