Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assertion during re-connect when server restarted #1650

Closed
DorpsGek opened this issue Jan 13, 2008 · 7 comments
Closed

assertion during re-connect when server restarted #1650

DorpsGek opened this issue Jan 13, 2008 · 7 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

On January 12 my client (beta2) crashed to the desktop during re-connect with an assertion failure when dihedral's server 3 restared as scheduled. A core dump is also available, if required.

Attachments

Reported version: 0.6.0-beta1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/1650
@DorpsGek
Copy link
Member Author

glx wrote:

Please attach crash.dmp.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3243

@DorpsGek
Copy link
Member Author

planetmaker wrote:

crash.dmp related to it.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3252

@DorpsGek
Copy link
Member Author

glx wrote:

It is a forced crash after displaying "Trying to execute a packet in the past!" in console.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3260

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Is this in any way reproduceable because I cannot found anything 'wrong' with the code.

The client would've been disconnected from the server while downloading because all connections are destroyed. Then the client would reconnect, but during the reconnect the queue of commands would be emptied. Furthermore the client can only join once the frame counter and friends are reset.

That's basically making none of the join scenarios a way to reproduce this issue.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3271

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 2, 2008

SmatZ wrote:

Maybe there is a packet in the packet queue. When the connection is lost, the packects in the queue are not erased.
Then, when starting NetworkGameLoop again, it loads the packet from previous game. It has higher packet number, so the game asserts.

Only theory, I haven't looked into the code.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3440

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 7, 2008

planetmaker wrote:

A few days ago (sorry, don't have crash report there), a probably similar (same?) thing happened. OTTD exited with a message along the lines "old data packet received". Previously I had tried several times to connect to that server unsucessfully. The reason for the unsuccessful login attempts propably are a combination of slow(er) hardware and monstrously big and train-overloaded game (was on ottdcoop with ~1000 trains with 1024^2 map).
IMO this kinda supports SmatZ view.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1650#comment3468

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Fixed

In r12367


This comment was imported from FlySpray: https://bugs.openttd.org/task/1650

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant