Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CC to Inner Walls Of Road Depots #1648

Closed
DorpsGek opened this issue Jan 13, 2008 · 3 comments
Closed

Add CC to Inner Walls Of Road Depots #1648

DorpsGek opened this issue Jan 13, 2008 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

foobar opened the ticket and wrote:

I'm currently working on 8bpp Graphics Replacement Project. We came to the conclusion that Company Colours are not supported on the inner walls of the road depots. Richk67 volunteered to create this small patch wich adds support for company colours on those particular sprites.

[quote=richk67]Four lines changed. I changed the CC of the inner wall of tram depots while I was at it. If the graphic doesnt have any CC, then this change makes no difference. But if a new graphic uses them, then they are correctly converted.[/quote]

It would be nice if this could be added to trunk, so that we can use the feature for the Graphics Replacement Project.

Thanks,

FooBar

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1648
@DorpsGek
Copy link
Member Author

Rubidium wrote:

I fear this might break already existing NewGRFs that replace the sprite but do not want the second company colour.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1648#comment3276

@DorpsGek
Copy link
Member Author

foobar wrote:

This also adds the second company colour? I didn't know :S

I'll discuss this with richk67, because only support for the original company colour should be added to the inner wall sprites (those don't have support for cc at all now).

Thanks for your time, I'll get back to this ASAP.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1648#comment3277

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

In r12447.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1648

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek