Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Patch setting for enable/disable Tree growth #1605

Closed
DorpsGek opened this issue Dec 30, 2007 · 10 comments
Closed

Feature: Patch setting for enable/disable Tree growth #1605

DorpsGek opened this issue Dec 30, 2007 · 10 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Frostregen opened the ticket and wrote:

revision 11722

This adds a patch-setting for enabling/disabling Tree Growth.
Savegame version is bumped to 84.

If the patch is active it disables the "OnTick_Trees" completely,
and "TileLoop_Trees" partly. (Grass still grows beneath trees)

This may be useful to prevent trees from filling the whole map,
or for scenario's where nice forests are wanted.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1605
@DorpsGek
Copy link
Member Author

Frostregen wrote:

minor coding style fix.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605#comment3119

@DorpsGek
Copy link
Member Author

Frostregen wrote:

again, coding style fix

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605#comment3121

@DorpsGek
Copy link
Member Author

Frostregen wrote:

simplified code. (patchfile is more readable now)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605#comment3122

@DorpsGek
Copy link
Member Author

Frostregen wrote:

added patchsetting: "Disable Tree grow in scenario editor",
which is a config setting only -> not saved with map.
synced with trunk r11811

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605#comment3222

@DorpsGek
Copy link
Member Author

planetmaker wrote:

updated to r13305

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605#comment4204

@DorpsGek
Copy link
Member Author

planetmaker wrote:

updated, simplified a lot and fixed coding style (actually by Belugas)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605#comment4254

@DorpsGek
Copy link
Member Author

skidd13 wrote:

The main problem with this patch is that some industries depend on tree growth, like lumber mills in tropic. And additionaly such industries can be defined via GRF, so the patch breaks current functionality. At it's current design the patch wont make it into trunk.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605#comment4262

@DorpsGek
Copy link
Member Author

Belugas wrote:

I can confirm that.
You can use it for patch packs, it's ok since it's "network" friendly, but it willnot make it in trunk because of the above reasons. And Planetmaker himself is aware of the reasons.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605#comment4263

@DorpsGek
Copy link
Member Author

Frostregen wrote:

In theory we could check for a nearby industry which depends on tree-growth, and allow those trees to grow anyway.
In practice this check could be quite a slowdown with many trees.

Maybe the other way round?
Industries let the trees grow around them? (Only if this patchsetting is enabled)


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605#comment4276

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Won't implement

You can switch to invisible trees. When trees don't grow, there won't be any if you demolish them. Also, it's not realistic ;-)


This comment was imported from FlySpray: https://bugs.openttd.org/task/1605

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant