Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing shores (not completely shore) #1564

Closed
DorpsGek opened this issue Dec 17, 2007 · 4 comments
Closed

missing shores (not completely shore) #1564

DorpsGek opened this issue Dec 17, 2007 · 4 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

BigBB opened the ticket and wrote:

Hi,

Frosch said on Fri, 16 Nov 2007 on the patch maillist for my 'completely shore' patch:

Normally an Action5 adds only new graphics to the game. ActionA is meant for replacing the old graphics.
Unfortunatelly this does not hold for the Action5 Coast Tile Graphics (they are the only exception) :(
Both OTTD and TTDP load the new shore graphics in a new location, but leave the old shore graphics in it's place.

Since I don't get any feedback for my 'completely shore' patch I thought: "What can I make better" and this is it:
I made a patch with "only" fix Frosch's suggestion and with an include of 10 new 'missing shore'-sprites (for each climates == 40). This are the 8 corner shores and the two canyon shores (this two are not in action 05-0D, but it will be possible now to include this with an newGRF and for compatibility: use of 07-9D and 07-A1 [but the old one will supported, too]).

This patch is only the first step with an include of these sprites and a fix of the use of this action.
The other steps (and own patches) are:
2: make OTTD possible to flood corner shores
3: make OTTD possible to flood the two canyon shore sprites and so include a canyou flooding (activated by a patch option)

missing_shores_v0.2_r11651.patch and openttd(w/d).grf are for the trunk,
/missing_shores_grf_v1_r11624.patch and shore.pcx are for svn/extra/ottd_grf

I've only drawn the temperate sprites in shore.pcx, the other 30th are a simple copy of the grass one (I'm sadly no artist). If you give me or better my patch an okay I search an artist for that.

Vantages are e.g.:
- the 32bpp crew can easy replace theese sprites
- the people who preferred the original graphics have now a complete shore view (if you have a look on the current one, you see there are miss something (you don't need a newGRF to see that))
- it fix one (ore more?) 'draw'-problems: the shore ground on docks (without a necessary of complicate code like the one in the 'completely shore'-patch)...

Regards,
BigBB

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1564
@DorpsGek
Copy link
Member Author

BigBB wrote:

The forum thread, in which I search for an artist: http://www.tt-forums.net/viewtopic.php?f=36&t=35350

An example pic, without (left part) and with (right part) my example sprites: http://www.tt-forums.net/download/file.php?id=82752


This comment was imported from FlySpray: https://bugs.openttd.org/task/1564#comment3013

@DorpsGek
Copy link
Member Author

BigBB wrote:

Skidd13 drawn the sprites and they look great.

Attached are the shore.pcx file by skidd13, the so changed/new openttd(d/w).grf files and a new patch (only md5 checksum change).

The pic missing_shore_sprites.png is an example and show all 40 sprites in use.

Regards,
BigBB

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1564#comment3018

@DorpsGek
Copy link
Member Author

BigBB wrote:

A little shore.pcx/nfo update by skidd13:

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1564#comment3036

@DorpsGek
Copy link
Member Author

Belugas closed the ticket.

Reason for closing: Implemented

in r11726 and r11727


This comment was imported from FlySpray: https://bugs.openttd.org/task/1564

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant