Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect string mapping for cargoes #1559

Closed
DorpsGek opened this issue Dec 16, 2007 · 3 comments
Closed

Incorrect string mapping for cargoes #1559

DorpsGek opened this issue Dec 16, 2007 · 3 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Johnny opened the ticket and wrote:

I tried to build a covered carriage and got the application error screen.

Attachments

Reported version: 0.6.0-beta1
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1559
@DorpsGek
Copy link
Member Author

Rubidium wrote:

It is an issue of the ECS (at least the Agricultural vector) + UKRS + the NewCargo set that cause the trouble. Removing any of those 'removes' the problem.

What happens is that some strings get redefined to something they should not be.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1559#comment3123

@DorpsGek
Copy link
Member Author

Rubidium wrote:

What happens exactly:

- ecsagri: add 'fish', set grf ID, set string IDs;
- newcargo: add 'fish', set grf ID, set string IDs;
- ecsagri: do action 3 mapping, set grf ID;
- MapNewCargoStrings map newcargo StringIDs to ecsagri StringIDs;
- draw cargo name -> get totally wrong string that requires parameters when you pass NULL as parameter list


This comment was imported from FlySpray: https://bugs.openttd.org/task/1559#comment3204

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r11862.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1559

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant