FS#1559 - Incorrect string mapping for cargoes

Attached to Project: OpenTTD
Opened by Johnny (Johnny) - Sunday, 16 December 2007, 17:48 GMT
Last edited by Remko Bijker (Rubidium) - Sunday, 13 January 2008, 12:33 GMT
Type Bug
Category NewGRF
Status Closed
Assigned To No-one
Operating System All
Severity Medium
Priority Normal
Reported Version 0.6.0-beta1
Due in Version 0.6.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


I tried to build a covered carriage and got the application error screen.
This task depends upon

Closed by  Remko Bijker (Rubidium)
Tuesday, 15 January 2008, 13:19 GMT
Reason for closing:  Fixed
Additional comments about closing:  In r11862.
Comment by Remko Bijker (Rubidium) - Sunday, 30 December 2007, 20:57 GMT
It is an issue of the ECS (at least the Agricultural vector) + UKRS + the NewCargo set that cause the trouble. Removing any of those 'removes' the problem.

What happens is that some strings get redefined to something they should not be.
Comment by Remko Bijker (Rubidium) - Wednesday, 09 January 2008, 23:02 GMT
What happens exactly:

- ecsagri: add 'fish', set grf ID, set string IDs;
- newcargo: add 'fish', set grf ID, set string IDs;
- ecsagri: do action 3 mapping, set grf ID;
- MapNewCargoStrings map newcargo StringIDs to ecsagri StringIDs;
- draw cargo name -> get totally wrong string that requires parameters when you pass NULL as parameter list