Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement selection of different screen resolutions on Mac #1483

Closed
DorpsGek opened this issue Nov 25, 2007 · 3 comments
Closed

Implement selection of different screen resolutions on Mac #1483

DorpsGek opened this issue Nov 25, 2007 · 3 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

PinguTux opened the ticket and wrote:

I have created a little patch that again allows the selection of different screen resolutions (in game options window). (regression since r11492)
The code is a modified version of src/video/cocoa/fullscreen.mm:ListModes.

I tested the patch with current trunk (r11520): it works fine here both with Quartz & QuickDraw window mode and fullscreen mode.

Attachments

Reported version: trunk
Operating system: Mac OS X


This issue was imported from FlySpray: https://bugs.openttd.org/task/1483
@DorpsGek
Copy link
Member Author

egladil wrote:

This is not the correct place in the code to do this, as different subdrivers might have different limits on what resolutions are available. For instance, in window mode you might want to allow a window that is large enough to span several physical displays.

The correct place to do this would be inside the subdrivers. For windowed mode it is a simple matter of cropping a predefined list to fit inside the display rectangle.

This will, however, be addressed.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1483#comment2809

@DorpsGek
Copy link
Member Author

PinguTux wrote:

OK.

The problem right now is that the ListModes function in Quartz & QuickDraw window drivers is essentially a no-op.
So there is currently no way to select a different resolution than 640x480 in window mode.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1483#comment2810

@DorpsGek
Copy link
Member Author

egladil closed the ticket.

Reason for closing: Implemented


This comment was imported from FlySpray: https://bugs.openttd.org/task/1483

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant