Bjarni wrote:

r11498 breaks right click scrolling on intel macs (I remember something about blackis having endian problems with scrolling). Scrollwheel scrolling works.

Also all the deprecated warnings for quickdraw showed up again (minor issue I guess we just need the right ifdef).

Also speed tests will be needed as blackis patch was a real slowdown.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment2784

egladil wrote:

Strange that it should break scrolling, since the event handling code isn't touched at all except for the mouse coordinate translation function, and that should effect more than just scrolling if it breaks.

The deprecated warnings would probably be better to handle by conditional compilation of the entire quickdraw subdriver. (If it's deprecated we shouldn't use it.)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment2785

egladil wrote:

This should remove the deprecated warnings, and use the correct driver for the running os x version.

Attachments

• osx_version_check.diff (5.22 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment2789

Rubidium wrote:

Since MacOS 10.6(?) some cocoa functions have become deprecated, used by the full screen driver:

[SRC] Compiling video/cocoa/fullscreen.mm
/Users/ingo/ottd/trunk/src/video/cocoa/fullscreen.mm: In member function ‘virtual void FullscreenSubdriver::UpdatePalette(uint, uint)’:
/Users/ingo/ottd/trunk/src/video/cocoa/fullscreen.mm:518: warning: ‘CGTableCount’ is deprecated (declared at /System/Library/Frameworks/ApplicationServices.framework/Frameworks/CoreGraphics.framework/Headers/CGDirectDisplay.h:459)

This task is a sub-task of FS 2782

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment6609

planetmaker wrote:

Actually that's more of a Quartz issue than a cocoa one. And yes, it's been deprecated in 10.6 (only).

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment6614

pyth wrote:

This patch removes the calls to CPS* process manager related stuff. These calls still work, but cause deprecation message in the console. The patched code should be good 10.3 - 10.6. The DEBUG line gives a compiler warning since DEBUG() does not know about the OSStatus type and casting it to (long int) doesn't work because of the # define. What would be the preferred way to solve this? Patch is only tested on 10.5...

Attachments

• FixDeprecatedCPSCalls.patch (0.85 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment6762

pyth wrote:

Improved version, making openTTD the front process even if started from the command line.

Attachments

• FixDeprecatedCPSCalls.patch (1.15 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment6765

michi_cc wrote:

Seems to work as far as I can see.

Added to the other OSX patches at http://www.icosahedron.de/cgi-bin/gitweb.cgi?p=ottd_osx.git

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment6771

michi_cc wrote:

Removing the CPS* calls was implemented in r17712. CGTableCount vanished in r17717.
Some remaining deprecated string functions where removed in r17711.

Besides the obvious QuickDraw stuff (that should have proper version guards and not be reported),
there shouldn't be any deprecated warnings left. Please report here if something is still missing.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment6787

planetmaker wrote:

I tested compilation on 10.6 for
with/out iconv
with/out freetype (link failure, see FS 3313)
with/out icu
with/out fontconfig
with/out png
with/out zlib
with/out cocoa (linking failure, see FS 3314)
with/out osx-sysroot
with/out network
with/out cocoa-quickdraw
with/out cocoa-quartz

and I didn't find any messages about the use of deprecated functions. From this POV, I think, this issue can be closed.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411#comment6947

michi_cc closed the ticket.

Reason for closing: Fixed

At least till 10.7 comes around.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1411