GrimRC wrote:

I've attached my patch to this comment. I had to make minor corrections to the way the tile-highlight functions work.

Attachments

• station_catchment_bug.patch (1.11 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/136#comment506

GrimRC wrote:

This is a correction of the last patch. Most _thd.var data has a _thd.new_var equivalent so that the old variables aren't lost and proper cleanup of dirty tile-highlighting blocks can occur. However, _thd.offs.x and _thd.offs.y don't have a backup variable, so we can not store them. Openttd doesn't seem to support jumping from one station type (for example, docks) straight to another (for example, road) because of this. This doesn't happen currently, as to go from one station to another you have to go through an intermediary stage, allowing the station catchment area highlight blocks to be cleared before _thd.offs.* is overwritten. Beware though, I could be wrong.

Attachments

• station_catchment_bug.patch (0.99 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/136#comment507

GrimRC wrote:

I forgot to mention there's another similar bug that's also fixed by my patch too. The bug is triggered by pressing the keyboard shortcut for a station builder (such as pressing '9' when the railway builder is open to change to station-building mode). The catchment area is not drawn till the mouse is moved, although the mouse cursor does change correctly to station placement mode.

This comment was imported from FlySpray: https://bugs.openttd.org/task/136#comment508

GrimRC wrote:

New patch, removing some superfluous and potentially dangerous SetTileSelectBigSize(0, 0, 0, 0).

Attachments

• station_catchment_bug.patch (1.07 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/136#comment510

Darkvater closed the ticket.

Reason for closing: Fixed

r6368

This comment was imported from FlySpray: https://bugs.openttd.org/task/136