TrueBrain wrote:

Please correct the spaces. The first char is a tab, not 4 spaces. See diff in browser. Also, space error in:

return (::GetVehicle(vehicle_id)-> IsStoppedInDepot());

And the () are useless. If you can correct this, it is ready for commit.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1346#comment2448

dihedral wrote:

try that :)

Attachments

• noai_VehicleIsInDepot_regression_v2.patch (4.59 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1346#comment2449

TrueBrain wrote:

k, now it is codewise okay, but some other comments (sorry, it is late, I missed them earlier :)):

VehicleIsInDepot <- the name doesn't tell it is also stopped. Maybe add two functions, that would be best :)

Second, the comment-block is not like other comment blocks. First, we use capitals at the start of a sentence, and a dot at the end. Second, the param comment at vehicle_id is a bit fuzzy. Please check other functions for some ideas :)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1346#comment2450

dihedral wrote:

changes:
* @param comment as found on line 36 and 43
* dot at end of line in comments ;-)
* shorter function names, AIVehicle::VehicleIsInDepot() makes as much sense as AIVehicle::IsInDepot() :-)
* added AIVehicle::IsStoppedInDepot()
* regression.nut includes calles to AIVehicle::IsStoppedInDepot()

Attachments

• noai_VehicleIsInDepot_regression_v3.patch (5.82 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1346#comment2451

TrueBrain closed the ticket.

Reason for closing: Implemented

Added in r11289

This comment was imported from FlySpray: https://bugs.openttd.org/task/1346