Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncating revision infos #1337

Closed
DorpsGek opened this issue Oct 14, 2007 · 2 comments
Closed

Truncating revision infos #1337

DorpsGek opened this issue Oct 14, 2007 · 2 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Ammler opened the ticket and wrote:

The Server page shows not the whole revision info. Maybe thats good for the server list servers.openttd.org. But also for detail page or the login screen on the client.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1337
@DorpsGek
Copy link
Member Author

Rubidium wrote:

  1. It is doing that by-design; ALL text that is send over the internet (in context of OTTD) is truncated at some point. For revisions it's fairly short, because there's no real reason to make them any longer.
  2. Not truncating it causes much more hassle (and possible buffer overflows)
  3. Truncating already happens way before it is actually send; clients can even join the server, just because we know about the limitation and have written it to cope with "too long" revision strings
  4. It works perfectly OK. Is your revision distinguishable from the rest?
  5. Changing it means changing the game network protocol, which makes servers invisible for everyone not running the version that changed the protocol (or something higher) OR makes them not display it correctly, which is what this bug report is about.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1337#comment2406

@DorpsGek
Copy link
Member Author

skidd13 closed the ticket.

Reason for closing: Invalid

(23:46:12) Ammller: http://bugs.openttd.org/task/1337 <-- could be closed

Closed by user request


This comment was imported from FlySpray: https://bugs.openttd.org/task/1337

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant