Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify road/rail GUI #1328

Closed
DorpsGek opened this issue Oct 11, 2007 · 5 comments
Closed

Unify road/rail GUI #1328

DorpsGek opened this issue Oct 11, 2007 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

skidd13 opened the ticket and wrote:

I started to unify and unmagic the road and rail GUI. There is still some work to do...

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1328
@DorpsGek
Copy link
Member Author

skidd13 wrote:

So replaced the magic numbers in the GUIs with enums.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1328#comment2396

@DorpsGek
Copy link
Member Author

skidd13 wrote:

Damn copy&past mistake.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1328#comment2397

@DorpsGek
Copy link
Member Author

skidd13 wrote:

Update:
- simplified some calculations
- made some enum values more descriptive

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1328#comment2399

@DorpsGek
Copy link
Member Author

skidd13 wrote:

Another update:
- moved some var definitions to their first usage positions
- removed some unnecessary vars
- removed further magic numbers

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1328#comment2403

@DorpsGek
Copy link
Member Author

skidd13 closed the ticket.

Reason for closing: Implemented

This comment was imported from FlySpray: https://bugs.openttd.org/task/1328

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek