Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoreplace for multiple NewGRF DMU sets fails #1264

Closed
DorpsGek opened this issue Sep 28, 2007 · 3 comments
Closed

Autoreplace for multiple NewGRF DMU sets fails #1264

DorpsGek opened this issue Sep 28, 2007 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Alistair opened the ticket and wrote:

r11132. If you are running a railway service operated by multiple DMUs operating as a single train, they will not be replaced by the group orders replace vehicles function. I am using UKRS v3.04 and have encountered no other problems with the feature when upgrading multiple headed loco-hauled trains (such as from EE1000 to Brush Type 4). I was replacing all of my Metro Cammel DMU units (consisting of two two car formations coupled together to give a four car unit) with Sprinter DMU units, when the group containing the DMUs was given its replacement orders and ordered to service as soon as possible, the trains entered the depot, were serviced and left again without being replaced by Sprinters. This is a minor but irritating bug as it makes upgrading my local services a far longer process than it should be. Sorry for not including a saved game but I only saved after I had manually replaced the vehicles for myself. I hope that this bug should be easily replicated for you anyway.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1264
@DorpsGek
Copy link
Member Author

Rubidium wrote:

Seems to be only happening with NewGRF multiple units, i.e. I cannot reproduce it without NewGRFs.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1264#comment2210

@DorpsGek
Copy link
Member Author

Bjarni wrote:

I knew this would happen. The problem is that the units are replaced one by one and Metro Cammel DMU and Sprinter EMUs can't be in the same train due to newgrf overwrite. The first unit is replaced and then it tries to attach the rest of the train. Because it fails to use the rest of the train, the replace is stopped.

I knew this could happen (didn't have this example though) so I'm already working on a solution. It's not done yet though and it could take a while since it's not a minor change

This comment was imported from FlySpray: https://bugs.openttd.org/task/1264#comment2211

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Fixed

in r14083

This comment was imported from FlySpray: https://bugs.openttd.org/task/1264

@DorpsGek DorpsGek added Autoreplace flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek