Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depot flooding #1228

Closed
DorpsGek opened this issue Sep 14, 2007 · 5 comments
Closed

depot flooding #1228

DorpsGek opened this issue Sep 14, 2007 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

SmatZ opened the ticket and wrote:

0.4, 0.5, r11001

When train heads or wagons are flooded in the depot, it behaves strange.
When the 'train' consists only of wagons, the depot will become undestroyable, leaving some ghost vehicles in the game.

Even flooded vehicles may be added to consinst and they will give power, and they can be sold for its original price.
Also, not all vehicles in a depot are flooded in the same moment.

Attachments

Reported version: 0.5.2
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1228
@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 7, 2007

SmatZ wrote:

Patch for r11224. Forces whole chain of flooded wagons to be deleted, so there won't be any shadow wagons.
Also, it forbids any moves with flooded wagons inside the depot.

However, current savegames with flooded wagons in train consinsts are not corrected - it would need new savegame version and I doubt anyone has savegame with that problem not intentionally caused.
It would also block from updating 0.5 branch.

Current state allows situations like the one in the attached screenshot, that triggers an assert.

Later, I will make a patch to forbid selling of flooded vehicles.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1228#comment2353

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 7, 2007

SmatZ wrote:

Sorry, one case missed, will post working solution later, also with patch for 0.5 branch...

This comment was imported from FlySpray: https://bugs.openttd.org/task/1228#comment2354

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 7, 2007

SmatZ wrote:

Patches for both 0.5 and trunk

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1228#comment2355

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 7, 2007

SmatZ wrote:

Next patch, forbidding sell of flooded vehicles.
Does not include previous patch!

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1228#comment2357

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 8, 2007

Rubidium closed the ticket.

Reason for closing: Fixed

In r11230.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1228

@DorpsGek DorpsGek closed this as completed Oct 8, 2007
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek