Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] invisible houses #1209

Closed
DorpsGek opened this issue Sep 6, 2007 · 10 comments
Closed

[PATCH] invisible houses #1209

DorpsGek opened this issue Sep 6, 2007 · 10 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Sep 6, 2007

SmatZ opened the ticket and wrote:

r11050

With new houses, that are often high, the city may become hard to manage even when buildings are transparent. When they are made invisible, it is much easier.

In attached pictures, it is easier to find the depot and trams.

Patch is configurable the same way as invisible trees.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1209
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 6, 2007

SmatZ wrote:

After a short talk with Belugas, I will do a complete 'everything-transparent-or-invisible' patch instead


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209#comment2072

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2007

SmatZ wrote:

New version, everything is now normal/transparent/invisible. Maybe something is not so useful, but at least it is unified now.
Added special way to turn off catenary.

Added buttons to switch if objects should be invisible instead of transparent.

normal.png - normal view, without any transparency
transparent.png - something is transparent
invisible.png - houses and catenary is invisible

As you can see, the city is now much easier to handle.

Attached - invisible2.diff . Maybe there are some problems with English...

Maybe somebody won't agree how signs can be made invisible, this could be another patch after some discussion. This patch includes only ability to make things invisible.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209#comment2087

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Updated to r11123, now catenary is drawn under low bridges, when they are transparent. (similiar it alredy behaves when catenary is transparent, but it causes some glitches...)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209#comment2140

@DorpsGek
Copy link
Member Author

Rubidium wrote:

That patch does way too many things in a single patch and it's way too big to get included. Furthermore something funky seems to happen in tree_cmd.cpp.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209#comment2204

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Too bad... later I will think over a way how to divide it into more patches.

The change tree_cmd.cpp - there was something like "if (trees_are_not_invisible) { .... a lot of code .... }; return;" - I changed it to "if (trees_are_invisible) return;" few lines earlier. Then I moved the whole block one tab to the left...

Actually, all it does:

  1. test for transparency is changed from "HASBIT(_transparent_opt, TO_xxx)" to "IsOptionTransparent(TO_xxx)"
  2. new check "IsOptionInvisible(TO_xxx)" is made, often resulting in earlier return from a drawing function
  3. the transparency toolbar was changed to fit buttons for switching transparency
  4. option to set transparent/invisible wires (el.rail, tram) - it was settable by TO_BUILDINGS, now it uses TO_CATENARY

(the parts 1 and 4 can be done as a separate patch, I will post it later)


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209#comment2206

@DorpsGek
Copy link
Member Author

SmatZ wrote:

First step - change "HASBIT(_transparent_opt, TO_xxx)" to "IsOptionTransparent(TO_xxx)", including some minor changes and new file transparency.h. Mostly search & replace change...

I will post next steps when this gets into trunk to make things easier

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209#comment2207

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Updated to r11190

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209#comment2213

@DorpsGek
Copy link
Member Author

DorpsGek commented Oct 1, 2007

SmatZ wrote:

Strange, uploaded file is empty... I placed it temporaly to http://88.146.45.107/ttd/transparent-r11190b.diff


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209#comment2219

@DorpsGek
Copy link
Member Author

Belugas wrote:

Here's a modification of your patch.
I almost commited it, but at the last minute, i felt it was not complete.
Some parts of the code still has the plain use of _transparent_opt as bit manipulation.
I think it needs to be wrapped more nicely and tightly.
I changed the name and added some stuff here and there.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209#comment2455

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 3, 2008

SmatZ closed the ticket.

Reason for closing: Implemented

r12547


This comment was imported from FlySpray: https://bugs.openttd.org/task/1209

@DorpsGek DorpsGek closed this as completed Apr 3, 2008
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant