Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing CMD_AUTO crashes remote server #1179

Closed
DorpsGek opened this issue Sep 1, 2007 · 1 comment
Closed

Removing CMD_AUTO crashes remote server #1179

DorpsGek opened this issue Sep 1, 2007 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Sep 1, 2007

TrueBrain opened the ticket and wrote:

Latest revision, and below (including 0.5.x) have a simple way to crash a remote server:

remove CMD_AUTO from a command, say, BuildHQ (it has to be a building command, and it has to build 2 tiles or more at once), remove the assert checking res == res2 in command.cpp, and join a server... build on a 2 tile structure (stadium, tunnel, ...), and you have a nice assert on the server (if enabled of course).

The problem is simple, but hard to solve I am afraid:

LANDSCAPE_CLEAR is called in test-phase and given back cost N for removing the structure + cleaning land on both tiles of the building. So it costs you N*2. While in reality it will only cost you N. So the assert happens, and the server is down.

2 possible ways to solve it: fix LANDSCAPE_CLEAR to understand 2 tile structures (hard, if not impossible). Other way: force CMD_AUTO server-side.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1179
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 4, 2007

Rubidium closed the ticket.

Reason for closing: Fixed

In r11040.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1179

@DorpsGek DorpsGek closed this as completed Sep 4, 2007
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant