ejoj wrote:

This bug goes at least back to r10827 as i saw it when playing now with that revision

This comment was imported from FlySpray: https://bugs.openttd.org/task/1132#comment1880

Rubidium wrote:

We need a savegame from just after you set the autorenew, so we can see what actually caused the figure to be too "low". I myself have not been able to reproduce it, so it doesn't happen in all cases.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1132#comment1886

frosch wrote:

The following procedure reproduces a bug, that looks similiar, though it is a "2^32-1 a lot of engines"-bug.
A savegame does not help, as the information that is wrong is not saved.

Situation:
- Multiplayer, 2 players.
- Player 1: Train # 1 "Kirby Paul Tank" ungrouped, Train # 2 "Chaney Junilee" in "Group 0", Train # 3 "Ginzu A4" in "Group 1".
- Player 2: Train # 1 "SH 8P" ungrouped, Train # 2 "Manley Morel DMU" in "Group 2", Train # 3 "UU 38" in "Group 3".

Now:
- either crash the Ginzu from player 1 with the Manley from player 2 (You will need horizontal/vertical track to do this. Btw. is this another bug?)
- or crash the Chaney with the Ginzu.

The result of both:
Player 1 ungrouped vehicles:
1 x Kirby (correct)
2^32-1 x Manley (only player 2 owned such a engine)
2^32-1 x UU (only player 2 owned such a engine)

Player 2 ungrouped vehicles:
2^32-1 x Chanley (only player 1 owned such a engine)
2^32-1 x Ginzu (only player 1 owned such a engine)
1 x SH (correct)

Note that the crashed vehicles are not yet removed.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1132#comment1982

frosch wrote:

Lol, I wish I had never reported the above procedure. There is no need to crash the vehicles.
The bug is simple. The amount of vehicles in the "ungrouped"-group is computed by subtracting the vehicles from all other groups from the total vehiclecount of a player. Unfortunatelly also the groups of other players are subtracted.

I hope the attached patch is everything needed.

Attachments

• DefaultGroupFix10990.patch (2.34 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1132#comment1986

frosch wrote:

Of course I overlooked something in such a small patch.

Attachments

• DefaultGroupFix10990_ver2.patch (2.43 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1132#comment1989

Rubidium closed the ticket.

Reason for closing: Fixed

In r10992.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1132