Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group vehicles counted twice after auto replace #1105

Closed
DorpsGek opened this issue Aug 5, 2007 · 4 comments
Closed

Group vehicles counted twice after auto replace #1105

DorpsGek opened this issue Aug 5, 2007 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Aug 5, 2007

Chris opened the ticket and wrote:

I know the screenshot shows that the bug happened in ChrisIN, but it can be reproduced with trunk and any ChrisIN version. The problem is, that each time I click the Manage list dropdown choose autoreplace and replace vehicles the group vehicle count won't stay the same but instead will count the old vehicles (which don't exist anymore) plus the new ones. That's definitely a bug :)

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1105
@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 5, 2007

Chris wrote:

Hmmm, something seems broken. Now I just deleted all my groups and when I choose All Trains/Ungrouped trains > Manage List > Replaced Vehicles there are two types shown which I don't even have with astronomous numbers and additionally the BR116 and BR152 I have isn't shown at all :(

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1105#comment1792

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 5, 2007

Chris wrote:

P.S. I never even built the BR92 shown in another bug.jpg, the VT137 from the second picture is not used anymore at all and was replaced by BR01 and then BR05.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1105#comment1793

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 5, 2007

Chris wrote:

Ok, just created a trunk r10791 game and the problem happens there too as expected (since ChrisIN doesn't change the groups or autoreplace code and nothing related to it). See attached savegames.

Reproduce like this:

  1. Build track stations, 4 trains
  2. Create Group TEST and add the 4 trains from the track
  3. Replace any locomotive by another and group vehicle count will double (increase by the amount of vehicles replaced)
  4. Repeat as often as you want and group vehicle count continues to increase by the number of vehicles replaced

The problem as shown in another bug and another bug2 couldn't be quickly reproduced in a newly started game, but that issue is probably due to something got messed up since I had a lot more groups and vehicles in my real game.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1105#comment1794

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 5, 2007

Rubidium closed the ticket.

Reason for closing: Fixed

In r10798.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1105

@DorpsGek DorpsGek closed this as completed Aug 5, 2007
@DorpsGek DorpsGek added Autoreplace flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant