Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group info #1042

Closed
DorpsGek opened this issue Jul 17, 2007 · 11 comments
Closed

Group info #1042

DorpsGek opened this issue Jul 17, 2007 · 11 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

MagicBuzz opened the ticket and wrote:

rev10595

This patch displays a panel at the bottom of the vehicules group window.
It shows the current year and last year profits, plus a "profit button" for the whole group.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1042
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 3, 2007

MagicBuzz wrote:

A small update in order to comply with the lastest trunk.
It also fix a small display bug with the "All vehicles" and "Ungrouped vehicles" panels.

r11039

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment2049

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 9, 2007

skidd13 wrote:

  1. DrawGroupProfitButton has some doubled with DrawVehicleProfitButton.
  2. The way you calculate the group profit might be unusefull cause now a group can have a green rating if one vehicle earns enough to cover the defict of the others. So counting the ratings instead of the money togehter for the button would be nicer IMO.
  3. I'm not sure about the position of the group info. Maybe there is a nicer place in the window.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment2094

@DorpsGek
Copy link
Member Author

MagicBuzz wrote:

*Bump*

According the #4037, this patch is still asked for.

So I rewritten the patch.
I removed the profit button as I don't think it's really usefull (thus, IMO it should be on the group name line).

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment9093

@DorpsGek
Copy link
Member Author

ABCRic wrote:

Thanks for the patch, it does exactly what I requested over at #4037.
Any chance this might make it to trunk?


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment9097

@DorpsGek
Copy link
Member Author

MagicBuzz wrote:

Here is a fix on the vehicle list in the group : the last entry was unused.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment9137

@DorpsGek
Copy link
Member Author

MagicBuzz wrote:

New feature : Group profit button is now visible in the group list. So you can easily and quickly see which groups loose or earn money.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment9144

@DorpsGek
Copy link
Member Author

MagicBuzz wrote:

Hmm, there were a small bug... Here is the lastest version

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment9145

@DorpsGek
Copy link
Member Author

MagicBuzz wrote:

There was a bug with the "all" group. I forgot to check the vehicle type when displaying the profit button, so the profit button was computed for all vehicle of any type...

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment9146

@DorpsGek
Copy link
Member Author

MagicBuzz wrote:

Hmpf... This time the bug is fixed (and tested, sorry)

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment9147

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042

@DorpsGek
Copy link
Member Author

3298 wrote:

For the record: Even though this has just been closed as Won't implement, a very similar patch has been implemented in r27822 a few months ago. I'm guessing everybody simply forgot this old ticket.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1042#comment14539

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant