Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Autorenew old vehicules #1029

Closed
DorpsGek opened this issue Jul 12, 2007 · 5 comments
Closed

Fix : Autorenew old vehicules #1029

DorpsGek opened this issue Jul 12, 2007 · 5 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

MagicBuzz opened the ticket and wrote:

Currently, if you set "service interval" to 0, and don't schedule depots in your orders, you don't have any chance of getting you vehicule renewed when it gets old. Thus, the autoreplace feature won't work as well.
To get it working, you must manually send your vehicules to depot.
Worst of all, if the autorenew patch is enabled, you aren't even warned about your vehicule gets old.

With this patch, when the vehicule reachs the age it has to be renewed, if not any service is scheduled (nor in the orders nor at intervals) it should automatically head to a depot to get renewed. This will also enable the autoreplace feature as well : all concerned vehicules will head to a depot.

Patch runs on rev10532

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1029
@DorpsGek
Copy link
Member Author

MagicBuzz wrote:

Changed the way the autoreplacement works.
Now all concerned vehicles won't go to depot immediately, but wait until you use the "send to service" button in vehicle list window.
This button now only impacts the vehicle concerned by an autoreplace.

I still have to check this won't impact the game when playing with servicing.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1029#comment1594

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 3, 2008

Alberth wrote:

In r12030, this problem seems still to exist.

With Vehicle-breakdown set to None, and the 'no-service-if-breakdown-disabled' configure patch, none of the vehicles go to a depot if they are beyond their life-time and autorenew is switched on.

In addition, trains and airplanes warn about obsolete vehicles, ships and road vehicles do not. Attached a saved game to experiment with, containing obsolete vehicles of all types.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1029#comment3453

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 4, 2008

MagicBuzz wrote:

There were a lot of code changes since this patch was released.
After a quick try, I wasn't able to fix it. I'll try to investigate more in the next days.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1029#comment3458

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 5, 2008

MagicBuzz wrote:

In fact, I found what was wrong with the patch after the small changes I did: most of your vehicles were not available anymore in shop, so it was impossible to replace them.

I tested this new version with your saved game with those results :
- Trucks and ships are immediately replaced, as they are still available
- If you use the "autoreplace" feature and set up a replacement model for your trains/planes, they are replacing correctly

r12059

PS: This need to be tested, I did only a few tests, but I'm unsure the patch works as expected with "normal" settings (breakdowns and servicing). I'll try to do some tests soon.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1029#comment3459

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/1029

@DorpsGek DorpsGek added Autoreplace flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant