Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when loading newgrf with long description #1025

Closed
DorpsGek opened this issue Jul 12, 2007 · 2 comments
Closed

Crash when loading newgrf with long description #1025

DorpsGek opened this issue Jul 12, 2007 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

bilbo opened the ticket and wrote:

In r10515:

When trying to add newGRF with longer description (like the one attached), the game crashes, saying "String too long for destination buffer". Ok, the description is quite long, but 540 characters is not so much and if there is some fixed size buffer, the description should be truncated at worst, not causing a crash.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1025
@DorpsGek
Copy link
Member Author

Belugas wrote:

May I point out that your grf is not very well received by TTDPatch itself? Look at the attached file...

From Action 08:
"Description
This is a longer description of the set. Typically it contains the name of the author and a copyright notice or other attribution. See GRFActionsDetailed for instructions to generate the necessary byte codes, and for restrictions on what characters you may use.

The description may be quite long, but should be short enough to fit in the description part of the GRF Status window, or a part of it may be cut off."

So please, do not ask us to fix what even TTDPatch does not tolerate...

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1025#comment1587

@DorpsGek
Copy link
Member Author

Belugas closed the ticket.

Reason for closing: Not a bug

PLease look at the comment I gave


This comment was imported from FlySpray: https://bugs.openttd.org/task/1025

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant